Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better congruence lattices #815

Merged

Conversation

james-d-mitchell
Copy link
Collaborator

This PR properly integrates the code for better congruence lattices written in conjunction with @mariatsalakou and @marinaanagno.

@james-d-mitchell james-d-mitchell added performance A label for issues or PRs that relate to performance. enhancement A label for issues or PRs that offer an enhancement to existing functionality labels Mar 15, 2022
@james-d-mitchell
Copy link
Collaborator Author

Just to mention that the test file: tst/extreme/cong.tst goes from taking 42,930ms before this PR to 1,877ms with this PR, which is a nearly 23 times speedup, and some evidence that the changes implemented do actually improve the performance

@james-d-mitchell
Copy link
Collaborator Author

@wilfwilson any idea why the github actions are failing with:

Run # optionally: clone specific package versions, in case we need to test
fatal: destination path 'digraphs' already exists and is not an empty directory.
Error: Process completed with exit code 128.

I don't think I changed anything related to this in this PR.

@wilfwilson
Copy link
Collaborator

I think this is gap-actions/setup-gap#38.

The script isn't successfully deleting an existing package.

Previously this was just annoying, because the installed package was in a directory called like digraphs-1.5.0 or something, which doesn't stop up us cloning into the digraphs directory.

But presumably Digraphs is just called "digraphs" in the package distribution, so it does already exist, and so we can't clone into it. So gap-actions/setup-gap#38 needs to be fixed.

@james-d-mitchell
Copy link
Collaborator Author

Thanks @wilfwilson!

@james-d-mitchell james-d-mitchell merged commit 584bc0c into semigroups:stable-4.0 Apr 20, 2022
@james-d-mitchell james-d-mitchell deleted the better-cong-lattice branch April 20, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A label for issues or PRs that offer an enhancement to existing functionality performance A label for issues or PRs that relate to performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants